[compiler] Redesign Repartition IR nodes to be naive coalesce only #12671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the execution semantics for the Spark backend. Instead of dispatching either to (a) a two-pass algorithm that scans and coalesces (shuffle=False) or (b) a two-pass algorithm that shuffles and then rekeys (shuffle=True), we use write/read instead.
patrick-schultz
previously requested changes
Mar 1, 2023
Comment on lines
-2014
to
-2020
| # test MatrixRepartition | ||
| if not hl.current_backend().requires_lowering: | ||
| rmt = hl.utils.range_matrix_table(20, 10, 3) | ||
| mt = rmt.repartition(5) | ||
| assert_contains_node(mt, ir.MatrixRepartition) | ||
| assert_unique_uids(mt) | ||
|
|
There was a problem hiding this comment.
Can we rewrite this and the TableRepartition one to use naive_coalesce, so the handle_randomness implementations still have test coverage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the execution semantics for the Spark backend. Instead of dispatching either to (a) a two-pass algorithm that scans and coalesces (shuffle=False) or (b) a two-pass algorithm that shuffles and then rekeys (shuffle=True), we use write/read instead.